Why is hb-warning a compilation unit?

[dmoody256]

Can these preprocessor checks just be added to the bottom of hb.hh?

It produces a lnk4221 warning on windows builds:
https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4221?view=vs-2019

[ebraminio]

Interesting, and worth to fix, however feel free also to just use harfbuzz.cc, single file, whole harfbuzz, for now :)

[behdad]

It was made into a compilation unit so the warnings are emitted just once.

So we have completely become slaves to compilers now.... What's wrong with a compilation unit having everything compiled out, perhaps because of preprocessor symbols?

[dmoody256]

in hb-warning.cc aren't they preprocessor errors and would make build systems assume compilation failed, and therefore fail a build?

When you say "emitted just once", you mean in the case of parallel compilation, the compiler wont spit out the same errors multiple times.

[dmoody256]

Could the preprocessor checks instead be at top of some main .cc file?

or if it was in some main header, it could set a processor flag (similar to header sentinals) so it only gets reported once?