Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongolian T + FVS3 displaying incorrect with Oyun Qagan Tig #234

Closed
KrasnayaPloshchad opened this issue Mar 1, 2016 · 10 comments
Closed

Comments

@KrasnayaPloshchad
Copy link

The sequence ᠊ᡨ᠊ᡨ᠋᠊ᡨ᠌᠊ᡨ᠍᠊ looks incorrect when using Oyun Qagan Tig font (from here) in HarfBuzz based environment.

This is displayed via Uniscribe (tested on LO for Windows, BabelPad and Notepad)
1
This is displayed via HarfBuzz (tested on both Chrome and Firefox)
2
In this case Mongolian T + FVS3 looks the same as T + FVS2

@behdad
Copy link
Member

behdad commented Mar 8, 2016

Does it reproduce with hb-view?

@behdad
Copy link
Member

behdad commented Mar 9, 2016

Redirect to a PNG file using --output-file or '>'

@KrasnayaPloshchad
Copy link
Author

I have tried to output a PNG file, but it always produce a file with mojibake text looks like '????????'. So what should I do? I have no idea.

@KrasnayaPloshchad
Copy link
Author

I have tested via Command Prompt, and when I open the properties window, I found only GBK code page (936 (ANSI/OEM - 简体中文 GBK)) available.

@KrasnayaPloshchad
Copy link
Author

I have reproduced it via cmder just now, but it still generating mojibake picture, and there is no suitable charset.

@khaledhosny
Copy link
Collaborator

Here is what I get with hb-view:
hb-view output

@behdad
Copy link
Member

behdad commented Apr 26, 2016

Ok, I'm on it. I've found the root cause: we allow matching to skip over FVSes. That's not desirable. Let me see what's the best fix.

On a side note: I have a hard time believing that this font really needs 150 GSUB lookups...

@khaledhosny
Copy link
Collaborator

The lookups seems to be fragmented for no clear reason, for example there are 5 isol lookups all are ligature substitutions that could have been combined together.

@behdad
Copy link
Member

behdad commented Apr 26, 2016

The lookups seems to be fragmented for no clear reason, for example there are 5 isol lookups all are ligature substitutions that could have been combined together.

Yeah, seems to be just for the heck of making debugging harder :). At least --debug came handy.

behdad added a commit that referenced this issue Apr 26, 2016
To make room to remember Mongolian Free Variation Selectors.
Part of fixing #234
@behdad behdad closed this as completed in b203050 Apr 26, 2016
@KrasnayaPloshchad
Copy link
Author

@khaledhosny Thank you very much.

gpgreen pushed a commit to gpgreen/harfbuzz that referenced this issue Jan 10, 2024
…z. (harfbuzz#234)

When we build a bundled `harfbuzz`, only enable `HAVE_CORETEXT` and
`HAVE_DIRECTWRITE` when the corresponding features are set.

We don't correct `HAVE_FREETYPE` here as it has other larger issues
that need to be resolved first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants