-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mongolian T + FVS3 displaying incorrect with Oyun Qagan Tig #234
Comments
Does it reproduce with hb-view? |
Redirect to a PNG file using --output-file or '>' |
I have tried to output a PNG file, but it always produce a file with mojibake text looks like '????????'. So what should I do? I have no idea. |
I have tested via Command Prompt, and when I open the properties window, I found only GBK code page (936 (ANSI/OEM - 简体中文 GBK)) available. |
I have reproduced it via cmder just now, but it still generating mojibake picture, and there is no suitable charset. |
Ok, I'm on it. I've found the root cause: we allow matching to skip over FVSes. That's not desirable. Let me see what's the best fix. On a side note: I have a hard time believing that this font really needs 150 GSUB lookups... |
The lookups seems to be fragmented for no clear reason, for example there are 5 isol lookups all are ligature substitutions that could have been combined together. |
Yeah, seems to be just for the heck of making debugging harder :). At least --debug came handy. |
To make room to remember Mongolian Free Variation Selectors. Part of fixing #234
@khaledhosny Thank you very much. |
…z. (harfbuzz#234) When we build a bundled `harfbuzz`, only enable `HAVE_CORETEXT` and `HAVE_DIRECTWRITE` when the corresponding features are set. We don't correct `HAVE_FREETYPE` here as it has other larger issues that need to be resolved first.
The sequence ᠊ᡨ᠊ᡨ᠋᠊ᡨ᠌᠊ᡨ᠍᠊ looks incorrect when using Oyun Qagan Tig font (from here) in HarfBuzz based environment.
This is displayed via Uniscribe (tested on LO for Windows, BabelPad and Notepad)
![1](https://camo.githubusercontent.com/34214cb2931793239eeb54793be2ef6a779efc95aae3281d6b6c809dc71c8fb6/68747470733a2f2f6f6f6f2e306f302e6f6f6f2f323031362f30332f30312f353664356363363937316236352e706e67)
![2](https://camo.githubusercontent.com/e6c7a7c967766cfdcc1b271a8b583db46c3b43ff031cbbef699aabb8b4bdfb12/68747470733a2f2f6f6f6f2e306f302e6f6f6f2f323031362f30332f30312f353664356363383861333231632e706e67)
This is displayed via HarfBuzz (tested on both Chrome and Firefox)
In this case Mongolian T + FVS3 looks the same as T + FVS2
The text was updated successfully, but these errors were encountered: