Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[subset] Remove debug burden #2360

Closed
behdad opened this issue Apr 22, 2020 · 0 comments
Closed

[subset] Remove debug burden #2360

behdad opened this issue Apr 22, 2020 · 0 comments
Assignees
@qxliu76
Labels
subset hb-subset related bugs

Comments

@behdad
Copy link
Member

behdad commented Apr 22, 2020

Currently in hb_subset_plan_t::add_table we always fetch source table just to print its size. We should not do the fetch if debugging subset is disabled. Basically add a if (HB_DEBUG_SUBSET) block around it.
@khaledhosny khaledhosny added the subset hb-subset related bugs label May 13, 2020
@behdad behdad closed this as completed in 7a60f4e Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qxliu76 qxliu76

Labels
subset hb-subset related bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@khaledhosny @behdad @qxliu76