Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[subset] Speed up ClassDef intersects #2826

Closed
behdad opened this issue Jan 21, 2021 · 0 comments · Fixed by #2827
Closed

[subset] Speed up ClassDef intersects #2826

behdad opened this issue Jan 21, 2021 · 0 comments · Fixed by #2827

Comments

@behdad
Copy link
Member

behdad commented Jan 21, 2021

From @garretrieger:

  • ClassDefFormat1 and 2 - Intersects_class skip array bounds safety checks. (big speedup)
    24.89 ms / subset vs 30.462 ms / subset
  • Convert target class to a HBINT and compare memory directly (skip casting conversion) (decent speedup)
  • Identify other places that could use similar changes.
behdad added a commit that referenced this issue Jan 21, 2021
@behdad
Speed up ClassDef/Coverage intersect methods
dbbcb02 
Just avoiding overhead as measured by Garret.
Should rewrite as dagger in the future and confirm that it has the
same benefits. Later on, rewrite as lfind() maybe.

Fixes #2826
@behdad behdad mentioned this issue Jan 21, 2021
Merged
behdad added a commit that referenced this issue Jan 21, 2021
@behdad
Speed up ClassDef/Coverage intersect methods
6463ee0 
Just avoiding overhead as measured by Garret.
Should rewrite as dagger in the future and confirm that it has the
same benefits. Later on, rewrite as lfind() maybe.

Fixes #2826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Speed up ClassDef/Coverage intersect methods harfbuzz/harfbuzz
1 participant
@behdad