Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private-use metric tags should be in all caps #3200

Closed
dscorbett opened this issue Sep 10, 2021 · 7 comments
Closed

Private-use metric tags should be in all caps #3200

dscorbett opened this issue Sep 10, 2021 · 7 comments

Comments

@dscorbett
Copy link
Collaborator

The private-use tags added in #1867 don’t follow the convention for private-use tags: “Private-use tags must use begin with an uppercase letter and use only uppercase letters or digits.”

@behdad
Copy link
Member

behdad commented Sep 13, 2021

Note that I also added a private style tag in 39c20d2

we should apply whatever we conclude to that as well. That one also uses one capital letter (last one).

@behdad
Copy link
Member

behdad commented Sep 13, 2021

Now to my main argument. I believe this is correct as is. The OT spec uses all-lowercase tags. It reserves all-uppercase tags for font vendors. Anything in-between is for system-developers, like HarfBuzz.

Originally I had added Harf/Buzz OT features as well. I wish I had not changed that (upon suggestion) to HARF/BUZZ in a62f37d

@behdad
Copy link
Member

behdad commented Sep 13, 2021

Note that other systems, like C/C++ are the same: C/C++ language say any identifier starting with __ are reserved. Those are used by system libraries though. The "reservation" does not apply to the implementation of the language itself. Similarly, the reservation doesn't apply to HarfBuzz, which is an implementation of OpenType.

@dscorbett
Copy link
Collaborator Author

Hmm, I guess that makes sense. I wish the spec would make that interpretation more explicit though.

behdad added a commit that referenced this issue Sep 14, 2021
Considered 'required', as opposed to existing 'HARF' and 'BUZZ',
consider them discretionary.

See discussion in #3200
@behdad
Copy link
Member

behdad commented Sep 14, 2021

Okay I re-added Harf and Buzz features, considering them required; whereas I see the HARF and BUZZ features as discretionary (user can turn on/off). So they serve distinct purposes now. Might need documentation update.

@behdad
Copy link
Member

behdad commented Sep 14, 2021

Good to close?

@behdad
Copy link
Member

behdad commented Sep 14, 2021

Note that other systems, like C/C++ are the same: C/C++ language say any identifier starting with __ are reserved. Those are used by system libraries though. The "reservation" does not apply to the implementation of the language itself. Similarly, the reservation doesn't apply to HarfBuzz, which is an implementation of OpenType.

This interpretation is also in line with Graphite's use of Silf etc. tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants