Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on mac OS 12.3 build 21E230: Shaping of mixed skin tone handshakes #3512

Closed
drott opened this issue Mar 28, 2022 · 3 comments · Fixed by #3514
Closed

Regression on mac OS 12.3 build 21E230: Shaping of mixed skin tone handshakes #3512

drott opened this issue Mar 28, 2022 · 3 comments · Fixed by #3514

Comments

@drott
Copy link
Collaborator

drott commented Mar 28, 2022

Similar to issue #2967 we observe problems with Apple Color Emoji shaping again for mixed skin tone sequences:

With ToT HarfBuzz, built against chafa support:

Expected:

build/util/hb-shape --shaper=coretext /System/Library/Fonts/Apple\ Color\ Emoji.ttc --unicodes 1FAF1,1F3FF,200D,1FAF2,1F3FC,000A
[u1FAF1.5.L=0+0|u1FAF2.2.R=3+800]

Actual (built in shaper):

build/util/hb-shape /System/Library/Fonts/Apple\ Color\ Emoji.ttc --unicodes 1FAF1,1F3FF,200D,1FAF2,1F3FC,000A                  
[u1FAF1.5.L=0+800|space=0+0|u1FAF2.2.R=0+0]

More sequences that need checking:

build/util/hb-shape /System/Library/Fonts/Apple\ Color\ Emoji.ttc --unicodes 1F469,1F3FB,200D,1F91D,200D,1F469,1F3FC,1F9D1,1F3FE,200D,2764,200D,1F9D1,1F3FC,1FAF1,1F3FF,200D,1FAF2,1F3FC,1F9D1,1F3FC,200D,2764,200D,1F48B,200D,1F9D1,1F3FE 

I suspect Apple changed something in their font again in terms of how these emoji sequences are mapped to AAT shaping features.

In Chrome, this appears as the two "halves" of the emoji appearing spaced apart and interleaved with following characters, plus various selection issues, compare
https://bugs.chromium.org/p/chromium/issues/detail?id=1310282

@jfkthame @litherum

@drott
Copy link
Collaborator Author

drott commented Mar 28, 2022

Screenshot from Firefox, where this also fails:

image

behdad added a commit that referenced this issue Mar 28, 2022
Fixes new Apple Color Emoji glyphs sequences rendering.

Fixes #3512
@behdad
Copy link
Member

behdad commented Mar 28, 2022

Okay this was easy: the residual "DELETED" glyphs from morx processing were blocking GPOS MarkToBase attackment. Just deleting such glyphs before GPOS processing fixes the issue.

Should add test.

behdad added a commit that referenced this issue Mar 28, 2022
Fixes new Apple Color Emoji glyphs sequences rendering.

Fixes #3512
behdad added a commit that referenced this issue Mar 28, 2022
Fixes new Apple Color Emoji glyphs sequences rendering.

Fixes #3512
behdad added a commit that referenced this issue Mar 28, 2022
Fixes new Apple Color Emoji glyphs sequences rendering.

Fixes #3512
@drott
Copy link
Collaborator Author

drott commented Mar 29, 2022

Great, thanks, verified!

image

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 30, 2022
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants