-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indic reordering of pre-base reordering characters is backwards #3863
Comments
This would be hard to do with our main sort. We would need to do a run after the sort and reverse the left-matras. |
behdad
added a commit
that referenced
this issue
Nov 4, 2022
behdad
added a commit
that referenced
this issue
Nov 5, 2022
behdad
added a commit
that referenced
this issue
Nov 5, 2022
behdad
added a commit
that referenced
this issue
Nov 5, 2022
behdad
added a commit
that referenced
this issue
Nov 5, 2022
behdad
added a commit
that referenced
this issue
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Unicode Standard, Version 15.0 clarifies that “For combining characters placed to the left of a base character, the combining characters start from the base character and are arranged leftward.” HarfBuzz’s USE shaper already does this.
The Indic shaper needs updating. Here is ⟨किॎ⟩ <U+0915, U+093F, U+094E>:
![किॎ](https://user-images.githubusercontent.com/1124347/199331645-46e53b58-90f6-4b4b-bd79-93f49c72b625.png)
The Myanmar shaper is a modification of the Indic shaper so it also needs updating. Here is ⟨ကေႄ⟩ <U+1000, U+1031, U+1084>:
![ကေႄ](https://user-images.githubusercontent.com/1124347/199332722-35759131-0052-4d38-8755-4c63bca7f2d7.png)
The Khmer shaper does not allow multiple pre-base vowels so this issue does not apply. It probably uses a copy of the Indic code for reordering too, though, so it still ought to be fixed.
The text was updated successfully, but these errors were encountered: