Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[use] Allow multiple FMs in a cluster #1720

Merged
merged 1 commit into from
May 24, 2019
Merged

[use] Allow multiple FMs in a cluster #1720

merged 1 commit into from
May 24, 2019

Conversation

dscorbett
Copy link
Collaborator

Instead of overriding certain characters to F (#525, #1399), this PR simply allows multiple FMs in a cluster. FM is split into FMAbv, FMBlw, and FMPst. Only one FMPst is allowed, because all FMPsts are non-marks, so the USE spec never inserts a dotted circle before one: if another FM precedes an FMPst, the FMPst just becomes an independent cluster. I didn’t want to deviate from the spec in a case where the current rendering would not get a dotted circle.

@behdad
Copy link
Member

behdad commented May 20, 2019

Only one FMPst is allowed, because all FMPsts are non-marks, so the USE spec never inserts a dotted circle before one: if another FM precedes an FMPst, the FMPst just becomes an independent cluster. I didn’t want to deviate from the spec in a case where the current rendering would not get a dotted circle.

But then why include FMPst at all? I don't like the "|" in there. Feels unjustified.

@dscorbett
Copy link
Collaborator Author

Currently, using my new categorization but the old behavior, C FMPst FMPst is two clusters: C FMPst and FMPst. If the machine used FMPst*, there would be one cluster. If I got rid of FMPst, there would be three clusters. I prefer following the spec, even when it’s a little weird, as long as it isn’t breaking anything, i.e. inserting dotted circles in valid text.

Unlike other *Pst categories, FMPst contains no marks, which is why it behaves differently than FMAbv and FMBlw. I had considered calling the category FMEnd to make it more obviously different. Would that help?

@behdad behdad merged commit d100cca into master May 24, 2019
@behdad
Copy link
Member

behdad commented May 24, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants