Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hb-coretext: remove unnecessary semicolons #1783

Closed

Conversation

mistydemeo
Copy link
Contributor

@mistydemeo mistydemeo commented Jun 18, 2019

Recent versions of clang feature a new warning, -Wextra-semi-stmt, which identifies empty statements. The CoreText code contains several macros which themselves end in semicolons, and the places they're called also terminated them with semicolons. The second semicolon triggered the new clang warning. Simply removing the duplicate semicolons silences it.

Sample error:

hb-coretext.cc:682:36: error: empty expression statement has no effect; remove
      unnecessary ';' to silence this warning [-Werror,-Wextra-semi-stmt]
      FAIL ("Buffer resize failed");

Recent versions of clang feature a new warning, -Wextra-semi-stmt,
which identifies empty statements. The CoreText code contains several
macros which themselves end in semicolons, and the places they're called
also terminated them with semicolons. The second semicolon triggered the
new clang warning. Simply removing the duplicate semicolons silences it.
@behdad
Copy link
Member

behdad commented Jun 18, 2019

Huh. Weird that we didn't catch this before. At any rate, the fix is to remove the semicolon in the macro. I'll fix locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants