[style] New API, hb_style_get_value #1890

ebraminio · 2019-08-04T07:13:36Z

Searches variation axes of a hb_font_t object for a specific axis first,
if not set, then tries to get default style values from different
tables of the font.

Related patches, master...ebraminio:style master...ebraminio:style2 master...ebraminio:italicangle #1468

behdad · 2019-08-04T08:54:17Z

Haven't looked at what you've done, but related:
#1888 (comment)

behdad · 2019-08-04T08:56:17Z

At first glance I like this, but see my comment linked above. This needs to hook up to font's currently-set variation values as well. And of course, what you have is the fallback path. The (missing) main path should be reading STAT table. And the API to expose that table is a lot more involved. So we shouldn't rush this, but keep evolving it till it's complete.

ebraminio · 2019-08-04T09:48:52Z

This needs to hook up to font's currently-set variation values as well.

The values here don't scale and are like hb_ot_var_find_axis_info.default_value which works with hb_face_t. Say in a font management system we want to know about different aspects of a face, why one should create a hb_font_t just to learn about a face.

And of course, what you have is the fallback path. The (missing) main path should be reading STAT table.

Was working on it as wanted to have it in separate change, done

And the API to expose that table is a lot more involved.

I'd say lets do that later, fallback won't be needed there even, mixing that with this just complicates things for a simple font crawling application.

ebraminio · 2019-08-04T10:44:10Z

If someday we decide to expose one of these flags, OS2.fselection.{UNDERSCORE,OUTLINED,STRIKEOUT} or post.isFixedPitch or head.macStyle.{UNDERLINE,OUTLINE,SHADOW} (which we don't, just theoretically), for example outlined flag which we can check both OS2 and head for better compatibility, don't we go for a naming like hb_bool_t hb_ot_style_is_outlined (hb_face_t *face), I think the API here is also similar to that, working upon a face, giving best effort result.

ebraminio · 2019-08-04T13:10:54Z

test/api/test-ot-style.c

+  /* XXX: It should be 900! */
+  g_assert_cmpfloat_hb (hb_ot_style_get_value (font, HB_OT_STYLE_TAG_WEIGHT), 1);\
+  /* XXX: It should be 50! */
+  g_assert_cmpfloat_hb (hb_ot_style_get_value (font, (hb_ot_style_tag_t) HB_TAG ('C','N','T','R')), 0.5);


Oh I see why but not sure if we like to do that :/

ebraminio · 2019-08-05T13:59:43Z

src/hb-ot-var-avar-table.hh

@@ -128,11 +162,24 @@ struct avar
    const SegmentMaps *map = &firstAxisSegmentMaps;
    for (unsigned int i = 0; i < count; i++)
    {
-      coords[i] = map->map (coords[i]);
+//       coords[i] = map->map (coords[i]);


guess can't reversed easily, test-ot-style test is working without this so if I could map unmap work I could reversed it correctly.

ebraminio · 2019-08-07T20:19:44Z

test/api/test-ot-style.c

+#define g_assert_cmpfloat_with_epsilon(n1, n2, epsilon) g_assert_cmpfloat ((int) roundf (n1), ==, (int) roundf (n2))
+#endif
+
+#define EPSILON 0.01


This is its precision on retrieving original coords which I believe is pretty good.

ebraminio · 2020-02-08T12:43:54Z

Dropped _ot_ as most of the tags can be considered for non OT fonts also.

How about renaming hb_style_get_value to hb_font_get_style_value? Guess hb_style_tag_t naming should be remained, or, going for hb_font_style_tag_t also?

ebraminio · 2020-02-12T15:15:58Z

@behdad can you review this also? Specially on hb_style_get_value vs hb_font_get_style_value and hb_style_t part. Thanks!

behdad · 2020-02-13T11:45:21Z

@behdad can you review this also? Specially on hb_style_get_value vs hb_font_get_style_value and hb_style_t part. Thanks!

Not now. I'm very conflicted on this still :). Let me recover a bit and be more comfortable with other code that has gone in first. Like to come to a conclusion on the pen stuff first. Thanks.

Searches variation axes of a hb_font_t object for a specific axis first, if not set, then tries to get default style values from different tables of the font.

ptem, used for AAT's tracking/`trak` table is equivalent to opsz of variable fonts. For variable AAT fonts, such as SFNS, ideally variable axis of the hb_font_t should be set and equivalent to ptem, https://crbug.com/1005969#c37

ebraminio · 2020-06-04T16:03:13Z

as previous off tracker agreement we had on having this as an experimental API, just like to experiment with the API on other projects to show its usefulness and guess there will be some clients for this just like the draw API clients found on github so they can comment on usefulness and correctness of the API also so let's have this as an experimental API for now.

ebraminio force-pushed the stat branch 4 times, most recently from c7325e7 to e2e4903 Compare August 4, 2019 10:32

ebraminio force-pushed the stat branch 4 times, most recently from 8cae97b to 899eacf Compare August 4, 2019 12:50

ebraminio commented Aug 4, 2019

View reviewed changes

ebraminio force-pushed the stat branch 2 times, most recently from b0245e2 to 50bf5cf Compare August 5, 2019 13:54

ebraminio commented Aug 5, 2019

View reviewed changes

ebraminio force-pushed the stat branch from 50bf5cf to 715e119 Compare August 7, 2019 14:09

This was referenced Aug 7, 2019

Implement fvar/avar inverse mapping logic #1893

Merged

[fvar] Use roundf instead hardcoding round logic #1894

Merged

[os2] Implement mean optical size fallback #1895

Merged

ebraminio force-pushed the stat branch 8 times, most recently from 49ae8f7 to c0e94e2 Compare August 7, 2019 20:04

ebraminio commented Aug 7, 2019

View reviewed changes

ebraminio force-pushed the stat branch from c0e94e2 to e264dfa Compare August 7, 2019 20:30

ebraminio force-pushed the stat branch 5 times, most recently from c443ad7 to 4d6582c Compare February 8, 2020 12:35

ebraminio force-pushed the stat branch 2 times, most recently from 52ebbd0 to 07b3639 Compare February 8, 2020 13:11

ebraminio changed the title ~~[style] New API, hb_style_get_value~~ [style] New API, hb_font_get_style_value Feb 8, 2020

ebraminio force-pushed the stat branch from 07b3639 to f72a404 Compare March 13, 2020 04:18

ebraminio changed the title ~~[style] New API, hb_font_get_style_value~~ [style] New API, hb_style_get_value Mar 13, 2020

ebraminio force-pushed the stat branch 4 times, most recently from 0847aa4 to 1cb782b Compare April 21, 2020 12:05

ebraminio mentioned this pull request Apr 25, 2020

[metrics] Add a private tag for Italic correction, Ital #2378

Closed

ebraminio force-pushed the stat branch from 1cb782b to 896bb32 Compare April 25, 2020 09:35

ebraminio force-pushed the stat branch 2 times, most recently from d9e5401 to ccb8e20 Compare June 4, 2020 11:31

ebraminio added 3 commits June 4, 2020 17:16

[style] New experimental API, hb_style_get_value

c771f42

Searches variation axes of a hb_font_t object for a specific axis first, if not set, then tries to get default style values from different tables of the font.

[style] give ptem value when asked for opsz

706fbcf

ptem, used for AAT's tracking/`trak` table is equivalent to opsz of variable fonts. For variable AAT fonts, such as SFNS, ideally variable axis of the hb_font_t should be set and equivalent to ptem, https://crbug.com/1005969#c37

[style] Adopt with meson

482d0f2

ebraminio force-pushed the stat branch from ccb8e20 to 7346b03 Compare June 4, 2020 12:46

[style] Hide behind HB_EXPERIMENTAL_API compile flag

f94a0e6

ebraminio force-pushed the stat branch from 7346b03 to f94a0e6 Compare June 4, 2020 13:55

ebraminio merged commit 759df46 into harfbuzz:master Jun 4, 2020

ebraminio deleted the stat branch June 4, 2020 16:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[style] New API, hb_style_get_value #1890

[style] New API, hb_style_get_value #1890

ebraminio commented Aug 4, 2019 •

edited

Loading

behdad commented Aug 4, 2019

behdad commented Aug 4, 2019

ebraminio commented Aug 4, 2019 •

edited

Loading

ebraminio commented Aug 4, 2019 •

edited

Loading

ebraminio Aug 4, 2019

ebraminio Aug 5, 2019 •

edited

Loading

ebraminio Aug 7, 2019

ebraminio commented Feb 8, 2020

ebraminio commented Feb 12, 2020 •

edited

Loading

behdad commented Feb 13, 2020

ebraminio commented Jun 4, 2020 •

edited

Loading

[style] New API, hb_style_get_value #1890

[style] New API, hb_style_get_value #1890

Conversation

ebraminio commented Aug 4, 2019 • edited Loading

behdad commented Aug 4, 2019

behdad commented Aug 4, 2019

ebraminio commented Aug 4, 2019 • edited Loading

ebraminio commented Aug 4, 2019 • edited Loading

ebraminio Aug 4, 2019

Choose a reason for hiding this comment

ebraminio Aug 5, 2019 • edited Loading

Choose a reason for hiding this comment

ebraminio Aug 7, 2019

Choose a reason for hiding this comment

ebraminio commented Feb 8, 2020

ebraminio commented Feb 12, 2020 • edited Loading

behdad commented Feb 13, 2020

ebraminio commented Jun 4, 2020 • edited Loading

ebraminio commented Aug 4, 2019 •

edited

Loading

ebraminio commented Aug 4, 2019 •

edited

Loading

ebraminio commented Aug 4, 2019 •

edited

Loading

ebraminio Aug 5, 2019 •

edited

Loading

ebraminio commented Feb 12, 2020 •

edited

Loading

ebraminio commented Jun 4, 2020 •

edited

Loading