-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the number of feature indices processed during feature collection. #2205
Conversation
I set the limit pretty high, we can tune it down later if needed. Looking at a merged copy of Noto Sans which contains support for everything other than CJK it uses ~500 feature indices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
Let's work on lookups later when we see a case timing out with lookups alone.
Please put the font that shows the issue on test/fuzzing/fonts :) |
Done :) |
Test case is still timing out, I'll try lowering the limit. |
Did some profling, now a lot of time is being spent in closure features (as opposed to collect features), probably needs some limiting applied in there as well. |
Now Script subsetting is the most expensive part, will need to apply feature limiting there too I suspect. |
4324e53
to
4088abd
Compare
So with all the fixes, it goes from taking ~5s to run the fuzzer file to ~0.08s. |
To fix #2191 .