[var] Fix hb_ot_var_get_axis_infos's offset semantic #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebraminio
commented
Mar 3, 2020
| start_offset = hb_min (start_offset, count); | ||
|
|
||
| count -= start_offset; | ||
| axes_array += start_offset; |
There was a problem hiding this comment.
This is the part that was wrong, start_offset isn't intended to be added to axes_array index but just used just as a AxisRecord index offset.
ebraminio
commented
Mar 3, 2020
| g_assert (info.tag == HB_TAG ('w','g','h','t')); | ||
|
|
||
| hb_ot_var_get_axis_infos (face, 1, &c, &info); | ||
| g_assert (info.tag == HB_TAG ('w','d','t','h')); |
There was a problem hiding this comment.
This didn't work before this change. was hammering stack…
|
@khaledhosny @behdad What do you suggest? Do you know clients that were using offset of the API? This overflows buffer for clients who iterating axis in usual way of HarfBuzz API. |
ebraminio
force-pushed
the
fix-offset-semantic
branch
from
9c86877
to
e54c6be
Compare
|
Pango fortunately doesn't use its offset, guess no client would use as it is broken anyway. |
ebraminio
force-pushed
the
fix-offset-semantic
branch
from
e54c6be
to
982ad40
Compare
The API was adding offset to input's infos buffer index also which is unusual between our APIs and wrong.
ebraminio
force-pushed
the
fix-offset-semantic
branch
from
982ad40
to
333831c
Compare
|
Any pointers? |
|
Yeah I think is safe to fix. No idea why I didn't just use sub_array to begin with... But yeah I put TODOs where I insert bugs apparently! |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API was adding offset to input's infos buffer index also which is
unusual between our APIs and wrong.