add "add_link()" with bias arg - take 2 #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase the change, it looks also nice and understandable as well :) |
blueshade7
force-pushed
the
add-link-with-bias2
branch
from
c52f74d
to
a459a01
Compare
blueshade7
force-pushed
the
add-link-with-bias2
branch
from
a459a01
to
b88cf32
Compare
|
branch rebased |
|
Thank you very much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of PR#2232 for fixes #2227 , removed “base” arg to
add_link()when it is actuallycurrent->headfrom cmap, gdef, gpos, gsub, cbdt, sbix subsetters.Two places where non-head base is used,
AnchorMatrix::serialize()andMarkArray::serialize()in hb-ot-layout-gpos-table.hh, convert base pointer to bias by callingto_bias(), then calls add_link() which takes bias replacing base.add_link() taking base is removed.