-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark against ttf-parser #2510
Conversation
e096965
to
98e04a8
Compare
b02a6d0
to
2e49be7
Compare
3422c18
to
ef1dfd7
Compare
let's close till we agree on benchmarking needs and so and c-api becomes a no_std also, otherwise can be considered useful I guess. |
What column is which? This is very bad way to present perf results. I know we follow up and fix in the other issue. Just saying. :-)
Huh? |
Oh, c-api wrapper of ttf-parser has dependency to Rust's standard library as RazrFalcon/ttf-parser#29 however ttf-parser's Rust core doesn't need Rust's standard library unlike its c wrapper which can be fixed. |
Absolutely! Feel free to give me feedback on it! Even better, having a look at its source https://github.com/harfbuzz/harfbuzz/blob/master/perf/perf-extents.hh#L43-L65 |
ttf-parser's extents calculates costly for variable font's when there is no actual coordinates so needs some tweaks, RazrFalcon/ttf-parser#28 and RazrFalcon/ttf-parser#27 to become comparable, it is still comparable when coordinate are given (
/vf
cases) and specially in CFF/CFF2rustybuzz is a gradual port of harfbuzz to rust https://github.com/RazrFalcon/rustybuzz that now doesn't have glyph related part of our font parsing logics still runs our test suite thanks to ttf-parser.
things can be improved on ot-draw if path command 'sanitization' be removed.
picked up from https://circleci.com/gh/harfbuzz/harfbuzz/146188 "build/perf/perf && rm -rf build" section