Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for msvc bots #2577

Merged
merged 2 commits into from Jul 18, 2020
Merged

Use GitHub Actions for msvc bots #2577

merged 2 commits into from Jul 18, 2020

Conversation

lazka
Copy link
Contributor

@lazka lazka commented Jul 18, 2020

Based on #2570

Someone needs to remove the linked appveyor project so it doesn't try to run anymore.

ebraminio and others added 2 commits July 18, 2020 19:15
Use the 'ilammy/msvc-dev-cmd' action for setting up the msvc env,
so we can use powershell everywhere.

Remove a directory from PATH which was interfering with the meson build
by providing an unrelated pkg-config.exe.
ebraminio added a commit that referenced this pull request Jul 18, 2020
@ebraminio ebraminio merged commit ab1079b into harfbuzz:master Jul 18, 2020
@ebraminio
Copy link
Collaborator

Wooow, thank you sooo much! How did you discover that! Fantastic! Thanks!!!!

@lazka
Copy link
Contributor Author

lazka commented Jul 18, 2020

Wooow, thank you sooo much! How did you discover that! Fantastic! Thanks!!!!

comparing meson logs to the appveyor one. This looked wrong: Found pkg-config: C:\Strawberry\perl\bin\pkg-config.BAT (0.26)

@ebraminio
Copy link
Collaborator

Wooow, thank you sooo much! How did you discover that! Fantastic! Thanks!!!!

comparing meson logs to the appveyor one. This looked wrong: Found pkg-config: C:\Strawberry\perl\bin\pkg-config.BAT (0.26)

Niiiice. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants