[ot] Keep substituted Default_Ignorables #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaledhosny
commented
Mar 3, 2021
src/hb-ot-layout.hh
Outdated
| !_hb_glyph_info_ligated (info); | ||
| !_hb_glyph_info_substituted (info) && | ||
| !_hb_glyph_info_ligated (info) && | ||
| !_hb_glyph_info_multiplied (info); |
There was a problem hiding this comment.
I’m not entirely sure the last two checks are actually needed, in my limited tests whenever _hb_glyph_info_ligated() or _hb_glyph_info_multiplied() return true, _hb_glyph_info_substituted() return true as well (but the reverse is not true).
Don’t replace Default_Ignorables with zero-width space if they are substituted or multiplied, not just when ligated. After this change, HarfBuzz output matches that of Uniscribe and CoreText for the new tests. Fixes #2883
khaledhosny
force-pushed
the
ignorables-sub
branch
from
2795889
to
36d0ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t replace Default_Ignorables with zero-width space if they are substituted or multiplied, not just when ligated.
After this change, HarfBuzz output matches that of Uniscribe and CoreText for the new tests.
Fixes #2883