[blob] Add failing versions of create API #3026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2567 New API: +hb_blob_create_or_fail() +hb_blob_create_from_file_or_fail() Use these in util/ to distinguish empty file from not-found file. Only err on the latter.
|
This, specifically, doesn't change any semantics of the existing API. In particular, |
khaledhosny
approved these changes
Jun 17, 2021
| @@ -71,15 +71,49 @@ hb_blob_create (const char *data, | |||
| hb_memory_mode_t mode, | |||
| void *user_data, | |||
| hb_destroy_func_t destroy) | |||
| { | |||
| if (!length) | |||
| return hb_blob_get_empty (); | |||
There was a problem hiding this comment.
Do we need to call destroy() here like in the (old) code below?
Ouch. |
behdad
added a commit
that referenced
this pull request
Jun 21, 2021
|
Since this is merged already, should we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2567
New API:
+hb_blob_create_or_fail()
+hb_blob_create_from_file_or_fail()
Use these in util/ to distinguish empty file from not-found file.
Only err on the latter.