Build and runtime fixes for Visual Studio 2015 #3448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename text_option_t in the templatized implementation of main_font_text_t so that we won't confuse between the text_option_t template with the actual struct type that inherits from the actual text_option_t structure, which will fix running on Visual Studio 2015. This will fix harfbuzz#3379.
|
These are two separate issues. Should not be in the same PR.
This is wrong. Those types' hash are not expected to match std::hash, but our own hash call with priority<2>. If that's not being matched, there's something else going on. I'll go ahead and revert that commit until we figure out what's going on.
Are you sure that's what's happening? I have a hard time believing that. |
|
For the hash issue first file an issue with the error, then discuss what you think is going on. |
|
Quite likely we won't want to support that compiler. |
This was referenced Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This attempts to improve the build and runtime situation when using Visual Studio 2015, by:
Adding specializations for
std::hashforhb_bytes_tandstruct hb_serialize_context_t::object_t, so that the build will not fail due to a C2338 error (The C++ Standard doesn't provide a hash for this type) on Visual Studio 2015. This will replace (and revert) commit 52c536b.Fix meson test failure on MSVC #3379, where the templatized implementation of
struct main_font_text_tconfuses the template typetext_options_twith the actualtext_options_t, where we inherit from the actualtext_options_twithshape_text_options_t.Things now build properly with Visual Studio 2015 and tests now pass, with the full list of options that we can pass into
hb-shape.exe.With blessings, thank you!