Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hb-ucd-table.hh GB18030-2022 Break the composed of 9 characters #4333

Closed
wants to merge 1 commit into from

Conversation

kiraskyler
Copy link

Remove character mappings for the following 9 fonts according to GB18030-2022 standard

GB18030-2022

codepoint = f92c, _hb_ucd_dm1_p0_map[740] = 90ce
codepoint = f979, _hb_ucd_dm1_p0_map[147] = 51c9
codepoint = f995, _hb_ucd_dm1_p0_map[558] = 79ca
codepoint = f9e7, _hb_ucd_dm1_p0_map[684] = 88cf
codepoint = f9f1, _hb_ucd_dm1_p0_map[772] = 96a3
codepoint = fa0c, _hb_ucd_dm1_p0_map[128] = 5140
codepoint = fa0d, _hb_ucd_dm1_p0_map[210] = 55c0
codepoint = fa18, _hb_ucd_dm1_p0_map[544] = 793c
codepoint = fa20, _hb_ucd_dm1_p0_map[661] = 8612

Remove character mappings for the following 9 fonts according to GB18030-2022 standard

[GB18030-2022](https://gitee.com/link?target=https%3A%2F%2Fopenstd.samr.gov.cn%2Fbzgk%2Fgb%2FnewGbInfo%3Fhcno%3DA1931A578FE14957104988029B0833D3)

codepoint = f92c, _hb_ucd_dm1_p0_map[740] = 90ce
codepoint = f979, _hb_ucd_dm1_p0_map[147] = 51c9
codepoint = f995, _hb_ucd_dm1_p0_map[558] = 79ca
codepoint = f9e7, _hb_ucd_dm1_p0_map[684] = 88cf
codepoint = f9f1, _hb_ucd_dm1_p0_map[772] = 96a3
codepoint = fa0c, _hb_ucd_dm1_p0_map[128] = 5140
codepoint = fa0d, _hb_ucd_dm1_p0_map[210] = 55c0
codepoint = fa18, _hb_ucd_dm1_p0_map[544] = 793c
codepoint = fa20, _hb_ucd_dm1_p0_map[661] = 8612
@kiraskyler
Copy link
Author

meson not fonud, May I ask if it is a compilation environment issue

@kiraskyler
Copy link
Author

There was an error during the build process. Can you help me? @tronical @nico @torarnv @yosh

@behdad
Copy link
Member

behdad commented Jul 20, 2023

We don't currently tailor the Unicode data. It comes straight from Unicode.

Why do you think we need to remove these 9 decompositions? Please elaborate.

cc @dscorbett @jfkthame

@kiraskyler
Copy link
Author

GB18030-2022 is a mandatory requirement of the Chinese government, requiring products used in designated fields to pass these certifications
In GB18030-2022, there are incompatibilities with unicode. It is recommended to keep unicode. If there are incompatibilities, such as the issue where the 9 characters above should not be displayed, they are considered as other issues, such as input method issues or text issues. Unicode recommends retaining these compatible glyphs for compatibility with previous displays.
Although unicode suggests retaining unicode in areas of conflict, these conversions have a significant impact on GB18030-2022. The unicode encoding used by harfbuzz comes from unicode, which inevitably conflicts with GB18030-2022.
How to do it specifically may need to be discussed, and there may be a more comprehensive plan

[unicode 22274 disruptive changes. pdf]( https://www.unicode.org/L2/L2022/22274-disruptive-changes.pdf
[unicode 01314-FAQ-GB18030. chm]( http://unicode.org/L2/L2001/01314-FAQ-GB18030.htm
[unicode 23003 gb18030 recommendations. pdf]( https://www.unicode.org/L2/L2023/23003-gb18030-recommendations.pdf

@kiraskyler
Copy link
Author

Should the upper software handle practices that are not compatible with Unicode?
Can the upper software pass certain encodings that should not be compatible when calling font display?

@behdad
Copy link
Member

behdad commented Jul 21, 2023

Higher-level can definitely override what HarfBuzz does. I like to hear from others, including @jfkthame

@behdad behdad closed this Jul 31, 2023
@behdad behdad reopened this Jul 31, 2023
@behdad
Copy link
Member

behdad commented Jul 31, 2023

Is this still needed?

@kiraskyler kiraskyler closed this by deleting the head repository Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants