Per syllable #4510
Open
Per syllable #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The use test expectations might need to be updated. |
|
Thanks. Yeah, the ZWNJ should do something there... |
The logic here was made to enable per-syllable matching for input, and not for backtrack/lookahead. However, if input-length is 1, this was setting per-syllable for lookahead, which caused the following: #4509 I have no idea why the tests are failing. Needs investigation. I also have no idea why this was not discovered before.
Another test fails now. Needs to be investigated.
|
I spent some more time on this. I have no idea what's going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #4509
but tests fail.