Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some errors in STAT table implementation #4579

Merged
merged 1 commit into from Feb 10, 2024
Merged

Fixed some errors in STAT table implementation #4579

merged 1 commit into from Feb 10, 2024

Conversation

chrsan
Copy link

@chrsan chrsan commented Feb 9, 2024

  • Fixed wrong return type for AxisValue::get_value (bool -> float)
  • Getting the actual axis value must add offsetToAxisValueOffsets to the offset for the axis value table

@chrsan chrsan mentioned this pull request Feb 9, 2024
Closed
ebraminio
ebraminio reviewed Feb 9, 2024
View reviewed changes
src/hb-ot-stat-table.hh
@@ -349,7 +349,7 @@ struct AxisValueFormat4

struct AxisValue
{
bool get_value (unsigned int axis_index) const
Copy link
Collaborator

@ebraminio ebraminio Feb 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😳😢

Thanks for fixing this 😊

@behdad behdad merged commit 1ab8822 into harfbuzz:main Feb 10, 2024
22 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Mar 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebraminio ebraminio ebraminio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrsan @ebraminio @behdad