[instancer] add a warning for CFF partial instancing

[qxliu76]

For #4700

[behdad]

CFF1 has no variations so no need there.

…

On Tue, May 7, 2024, 2:00 PM Qunxin Liu ***@***.***> wrote: For #4700 <#4700> ------------------------------ You can view, comment on, or merge this pull request online at: #4705 Commit Summary - d58cb7f <d58cb7f> [instancer] add a warning for CFF partial instancing File Changes (2 files <https://github.com/harfbuzz/harfbuzz/pull/4705/files>) - *M* src/hb-subset-cff1.cc <https://github.com/harfbuzz/harfbuzz/pull/4705/files#diff-c3f11e59bc27704430d94eb7ee8b18f23772ba9d45724ce8c812030422ad6537> (3) - *M* src/hb-subset-cff2.cc <https://github.com/harfbuzz/harfbuzz/pull/4705/files#diff-2d6fe0985f7052b5ca12fff4353957cd49a20a75e64b89788e7de72571179452> (3) Patch Links: - https://github.com/harfbuzz/harfbuzz/pull/4705.patch - https://github.com/harfbuzz/harfbuzz/pull/4705.diff — Reply to this email directly, view it on GitHub <#4705>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABC4KYIE2RQEY52G72BFULZBE6FLAVCNFSM6AAAAABHLXKKD6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI4DIMRSGM4DEMA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[qxliu76]

Updated the PR. Thanks!

[ebraminio]

Maybe subsetter can raise some similar warning for unsupported AAT layout tables subsetting, or maybe it could suggest adding keep gid flag and keep the layout table if requested, sorry if this is considered already and I'm just unaware of or doesn't worth considering.

[behdad]

Feel free to add l send PR.