[dwrite] Use new again and enable the build on msys2 bots #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebraminio
force-pushed
the
dwrite
branch
4 times, most recently
from
0c220e6
to
9567650
Compare
|
I should also note that hb-shape crashes if I issue |
ebraminio
force-pushed
the
dwrite
branch
2 times, most recently
from
a5226ee
to
0a90af9
Compare
|
The crashing issue was because of lack of vtable initialization with plain malloc that I couldn't understand without @andlabs help. Thanks! |
ebraminio
changed the title
ebraminio
force-pushed
the
dwrite
branch
3 times, most recently
from
02a0d03
to
788445b
Compare
ebraminio
changed the title
ebraminio
force-pushed
the
dwrite
branch
3 times, most recently
from
0ef35fa
to
4947fb4
Compare
…n msys2 bots Special thanks to @andlabs
ebraminio
changed the title
fanc999
pushed a commit
to fanc999/harfbuzz
that referenced
this pull request
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#884 fixed most of the GCC compile issues, this enables it on msys2 bots.
The way I am checking validity of headers may don't seem good. The issue is msys2 and mingw-w64 headers are not complete and I am checking that using thatthis now just downloads the needed header#ifdef. I proposed a fix to upstream also but that can take years to have here so I am applying this workaround.Also applied #884 (comment) now that it doesn't have any other hb-directwrite.cc perhaps should be separated but don't know if worths to