Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appropriate fix for msys2 bot fail on gen-def.py #894

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

ebraminio
Copy link
Collaborator

Reverts the hack happened here #885 with @anthrotype help. Thanks!

@ebraminio ebraminio changed the title Appropiate fix for msys2 bot fix on gen-def.py Appropriate fix for msys2 bot fix on gen-def.py Mar 16, 2018
@anthrotype
Copy link
Member

I hope that doesn't break other stuff :)
it also changes the encoding of the stdout/stderr streams, so if we print anything to the console and the latter uses some weird ANSI codepage..

Maybe you should only set that env variable when calling glib-mkenums

@anthrotype
Copy link
Member

https://ci.appveyor.com/project/harfbuzz/harfbuzz/build/1.0.1076/job/ici5gkiglm79meo6#L556

still getting UnicodeDecodeError.

Are we sure that cmake's execute_process that calls the glib-mkenums script is reading the PYTHONIOENCODING variable properly?

maybe you could try doing SET(ENV{PYTHONIOENCODING} "UTF-8") just before EXECUTE_PROCESS(...)?
https://cmake.org/pipermail/cmake/2011-August/045665.html

@ebraminio
Copy link
Collaborator Author

msys2 bot which is failing uses autotools, Behdad's territory, I fear to touch it and then get blamed :D

@behdad
Copy link
Member

behdad commented Mar 16, 2018

Um. No blame. :) I'll check.

@ebraminio
Copy link
Collaborator Author

Hehehe, done, lets see.

@ebraminio ebraminio changed the title Appropriate fix for msys2 bot fix on gen-def.py Appropriate fix for msys2 bot fail on gen-def.py Mar 16, 2018
@anthrotype
Copy link
Member

msys2 bot which is failing uses autotools

oh I see. I presume it would give the same error if one attempted to run glib-mkenums under cmake on msys2, if that env variable isn't set.

@ebraminio
Copy link
Collaborator Author

@anthrotype does it look good now? If so I think this can be merged now.

@ebraminio ebraminio merged commit 8d1b408 into harfbuzz:master Mar 16, 2018
@ebraminio ebraminio deleted the gen-def branch March 16, 2018 21:35
fanc999 pushed a commit to fanc999/harfbuzz that referenced this pull request Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants