Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subset] Restore subset to hb-subset-fuzzer. #895

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

garretrieger
Copy link
Collaborator

No description provided.

@garretrieger
Copy link
Collaborator Author

@ebraminio Hey I'm having some issues with a single windows bot failing on this PR. I'm not able to replicate on a windows machine locally. Could you help me track down why it's failing?

@ebraminio
Copy link
Collaborator

ebraminio commented Mar 17, 2018

msys2 bots usually complain about an interesting aspect of the project and now this bot is a 32bit one and IIRC it is the only autotools bot that runs tests on 32bit so the bug can be about some 32-bit int variable not enough to contain all the needed range. It has one issue for me, msys2's gdb, at least on my machine, doesn't seem to work so lets make sure your setup is correct,

  1. Install msys2 from https://www.msys2.org
  2. Open "MSYS2 MingGW 32-bit" shortcut (not any other)
  3. pacman --noconfirm -S mingw-w64-i686-{freetype,cairo,icu,gettext,gobject-introspection,gcc,gcc-libs,glib2,graphite2,pkg-config,python2,ragel}
  4. ./autogen.sh --with-uniscribe --with-freetype --with-glib --with-gobject --with-cairo --with-icu --with-graphite2
  5. make
  6. make check

If this couldn't reproduce the issue let me know.

@ebraminio
Copy link
Collaborator

Weird, it didn't have issue when I ran the instruction inside the bot, so my argument was not valid, maybe it just needs rebuild (which if is the case we should still be concerned but at least we know it doesn't happen always).

@ebraminio
Copy link
Collaborator

Restarted the bot but the fail was consistent :/

@garretrieger
Copy link
Collaborator Author

I tried your steps and was also unable to reproduce. Any other ideas of what the cause could be?

I think I'll just start commenting out parts of the code and checking that against the bots to try and narrow down where specifically is causing issues.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 64.721% when pulling 9b2663c on googlefonts:fuzzer into 957e775 on harfbuzz:master.

@ebraminio
Copy link
Collaborator

Oh interesting, any idea how it is fixed now? That doesn't matter of course but is just interesting :)

@garretrieger
Copy link
Collaborator Author

hmmm, all I did was rebase against master and re-ran the bots. I suppose some recent change must have fixed something?

@garretrieger garretrieger changed the title [subset] Attempt to fix hb-subset-fuzzer (DO NOT MERGE) [subset] Attempt to fix hb-subset-fuzzer. Mar 19, 2018
@garretrieger garretrieger changed the title [subset] Attempt to fix hb-subset-fuzzer. [subset] Restore subset to hb-subset-fuzzer. Mar 19, 2018
@garretrieger garretrieger merged commit b5c7d6c into harfbuzz:master Mar 19, 2018
@garretrieger garretrieger deleted the fuzzer branch March 19, 2018 22:06
@khaledhosny khaledhosny added the subset hb-subset related bugs label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subset hb-subset related bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants