-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] [v0.11] lighthouseOptions.throttlingMethod
always set to provided
#195
Comments
lighthouseOptions.throttlingMethod
always set to provided
lighthouseOptions.throttlingMethod
always set to provided
Hi @mwskwong, thanks for the issue. I've pushed up a fix for overriding the throttling. v0.11 was meant to re-introduce throttling on by default but the configuration was actually set up incorrectly, I've gone with a custom throttling config to account for the CPU and network already getting trashed. Saying that, Unlighthouse has been and will never be for producing accurate performance metrics that are effected by variability. Try out 0.11.4 and let me know if it's working better for you. |
For the original intent of this issue, it seems to load the correct config now in v0.11.4. However, would you mind elaborating on the "we need a custom throttling profile to account for the CPU/ network already getting blasted" part? i.e. the rationale of loosening the throttling. |
The issue to solve is that the performance scores reported by Unlighthouse are either always too low (when throttling is enabled) or too high (because throttling is disabled). Users expect to see performance scores matching PSI. While we're running multi-threaded Lighthouse scans there isn't really a solution besides fine-tuning the throttling |
Describe the bug
Despite
throttle
istrue
by default,lighthouseOptions.throttlingMethod
always has the valueprovided
, effectively disabling throttle entirely. Explicitly settinglighthouseOptions.throttlingMethod
in the config file doesn't work as well.Command used:
Config file:
Debug output (some of the paths are masked):
Reproduction
See above
System / Nuxt Info
System: OS: macOS 14.2.1 CPU: (8) arm64 Apple M1 Pro Memory: 1.26 GB / 16.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 18.19.1 - /usr/local/bin/node Yarn: 1.22.19 - /usr/local/bin/yarn npm: 10.2.4 - /usr/local/bin/npm pnpm: 8.15.4 - ~/Library/pnpm/pnpm Browsers: Brave Browser: 110.1.48.171 Chrome: 121.0.6167.184 Edge: 122.0.2365.63 Firefox Nightly: 122.0a1 Safari: 17.2.1
Also reproducible in GitHub Actions
ubuntu-latest
The text was updated successfully, but these errors were encountered: