Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HTTP API listen on 0.0.0.0 like other services #87

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

DukeFerdinand
Copy link
Contributor

PR Summary

Makes the HTTP API listen on 0.0.0.0 like the rest of the services :)

This is required mainly to allow every service to operate inside of a container, where 127.0.0.1 isn't very useful as you can't hit the service from the outside.

Issues

Fixes #86

How to test

Run the application as normal with your desired config. Here's an example config based on the one I'm using for my app:

[hls]
enabled = true
port = 8080
need_record = true

[rtmp]
enabled = true
port = 1935

Command like the I'm using to run this locally:

cargo run --bin xiu -- -c ~/path/to/your/config.toml

You should see the http api now listed as running on 0.0.0.0:8000 or however you've configured it.

...truncated...
[2023-12-25T21:03:19Z INFO  hls::server] Hls server listening on http://0.0.0.0:8080
[2023-12-25T21:03:19Z INFO  rtmp::rtmp] Rtmp server listening on tcp://0.0.0.0:1935
[2023-12-25T21:03:19Z INFO  xiu::api] Http api server listening on http://0.0.0.0:8000

Next Steps

I just wanted to get this out there for now, but soon I'd like to make a PR that adds a --host as well as host or maybe address config options to each of the target services to make this truly customizable for any strange configuration end users might need :)

@harlanc harlanc merged commit 999c87a into harlanc:master Dec 25, 2023
1 check passed
@harlanc
Copy link
Owner

harlanc commented Dec 25, 2023

PR Summary

Makes the HTTP API listen on 0.0.0.0 like the rest of the services :)

This is required mainly to allow every service to operate inside of a container, where 127.0.0.1 isn't very useful as you can't hit the service from the outside.

Issues

Fixes #86

How to test

Run the application as normal with your desired config. Here's an example config based on the one I'm using for my app:

[hls]
enabled = true
port = 8080
need_record = true

[rtmp]
enabled = true
port = 1935

Command like the I'm using to run this locally:

cargo run --bin xiu -- -c ~/path/to/your/config.toml

You should see the http api now listed as running on 0.0.0.0:8000 or however you've configured it.

...truncated...
[2023-12-25T21:03:19Z INFO  hls::server] Hls server listening on http://0.0.0.0:8080
[2023-12-25T21:03:19Z INFO  rtmp::rtmp] Rtmp server listening on tcp://0.0.0.0:1935
[2023-12-25T21:03:19Z INFO  xiu::api] Http api server listening on http://0.0.0.0:8000

Next Steps

I just wanted to get this out there for now, but soon I'd like to make a PR that adds a --host as well as host or maybe address config options to each of the target services to make this truly customizable for any strange configuration end users might need :)

PRs are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http api doesn't listen on 0.0.0.0 - can't be used in docker container
2 participants