Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any example for using service discovery (e.g. consul) with this code? #24

Closed
rcholic opened this issue Jan 20, 2018 · 3 comments
Closed

Any example for using service discovery (e.g. consul) with this code? #24

rcholic opened this issue Jan 20, 2018 · 3 comments

Comments

@rcholic
Copy link

rcholic commented Jan 20, 2018

From my understanding, the current design does not use service discovery, instead each service is deployed in a single docker container. I was wondering how to integrate consul into this implementation, and how to run multiple instances for each service.

Thanks
@harlow
Copy link
Owner

harlow commented Mar 14, 2018

great question. haven't used consul before so maybe i'll spike something out when i have some free time and see if it feels like a good fit for this repo

harlow added a commit that referenced this issue Mar 15, 2018
@harlow
Add Consul for service discovery
64f6776 
Previously the repository was using "links" in docker-compose to connect
to the other services. To simulate a scenario where each service is run
independently we can use Consul to allow the services to discover
each other.

* Leverage Consul for service registry

Addresses: #24
@harlow harlow mentioned this issue Mar 15, 2018
Merged
@harlow
Copy link
Owner

harlow commented Mar 15, 2018 •
edited
Loading

I was wondering how to integrate consul into this implementation, and how to run multiple instances for each service.

this i'm not sure about... Looks like some load balancing will be needed: https://grpc.io/blog/loadbalancing
https://github.com/grpc/grpc/blob/master/doc/load-balancing.md

harlow added a commit that referenced this issue Mar 15, 2018
@harlow
Add Consul for service discovery (#25)
93fdfa5 
Previously the repository was using "links" in docker-compose to connect
to the other services. To simulate a scenario where each service is run
independently we can use Consul to allow the services to discover
each other.

* Leverage Consul for service registry
* Move client/server registry into run methods

Addresses: #24
@harlow
Copy link
Owner

harlow commented Mar 15, 2018

closing consul issue, added new issue for load balancing: #26

@harlow harlow closed this as completed Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rcholic @harlow