Allow InterProcessLock to receive a pathlib.Path object

[cool-RR]

No description provided.

[harlowja]

Sounds good to me as long as it will work on both py2.7 and py3.x

[cool-RR]

I think it will since you don't even need the package, just call str(path)
on the paths and you're done. You need pathlib just for the tests, and
there is a python 2 backport.
On Dec 7, 2015 01:10, "Joshua Harlow" notifications@github.com wrote:

Sounds good to me as long as it will work on both py2.7 and py3.x

—
Reply to this email directly or view it on GitHub
#16 (comment).

[harlowja]

Agreed, although probably better to call https://docs.python.org/3/library/os.html#os.fsencode if we can...

[harlowja]

Ok checkout #17 (I'll add some tests but seems to work locally).

[cool-RR]

Be wary of isinstance(path, pathlib.Path), because some people, like me,
bundle pathlib in another package so this check would fail for them. I
would skip the pathlib import completely, even though it's in try. You
can basically check if it's a string, and if it's not turn it into a string
in your favorite way.

On Mon, Dec 7, 2015 at 2:48 AM, Joshua Harlow notifications@github.com
wrote:

Ok checkout #17 #17 (I'll add
some tests but seems to work locally).

—
Reply to this email directly or view it on GitHub
#16 (comment).

[harlowja]

Hmmm, why u bundling it 😦

I get that concern, but it seems like a 1% case (and not especially a 1% case that I like, bundling stuff IMHO is ummm not helping the python ecosystem in general, although I get the reasons why people do it, I just don't agree with them, ha).

[cool-RR]

Also consider there are alternatives to Pathlib which act similarly but
will still fail your test. You can't isinstance all of them but you can do
str(path) which will work for all of them, I think.

Sent from my phone.
On Dec 7, 2015 9:17 PM, "Joshua Harlow" notifications@github.com wrote:

Hmmm, why u bundling it [image: 😦]

I get that concern, but it seems like a 1% case (and not especially a 1%
case that I like, bundling stuff IMHO is ummm not helping the python
ecosystem in general, although I get the reasons why people do it, I just
don't agree with them, ha).

—
Reply to this email directly or view it on GitHub
#16 (comment).

[harlowja]

Fair enough, maybe should just do str() as u said...