Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid inclusion #144

Closed
EmanuelLoos opened this issue Jan 23, 2022 · 10 comments
Closed

F-Droid inclusion #144

EmanuelLoos opened this issue Jan 23, 2022 · 10 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@EmanuelLoos
Copy link

Are there any plans for Harmonoid to be available on F-Droid?

F-Droid is an (alternative) Appstore for Android only allowing Apps that are completely free software and which are built by F-Droid into the official repository. It is therefore more secure and might make the project more popular in the Free Software community than APKs distributed on GitHub.
Apart from that it would also make automatic updates easier though that is not my point.

@mytja
Copy link
Member

mytja commented Jan 25, 2022

I will try my best to include it within F-Droid when new release is published.

@mytja mytja self-assigned this Feb 23, 2022
@DovePod
Copy link

DovePod commented Mar 6, 2022

I would love you see this on F-Droid!

@mytja
Copy link
Member

mytja commented Apr 27, 2022

So, v0.2.2 has been released. We've added Android support again, but the problem is that Harmonoid has become partially propriatery. Thus, we cannot build on F-Droid's servers. Once & IF it becomes fully open-source again, we'll be able to publish it to F-Droid, until then, I sadly cannot help. Marking this as wontfix.

@mytja mytja added the wontfix This will not be worked on label Apr 27, 2022
@EmanuelLoos
Copy link
Author

EmanuelLoos commented Apr 28, 2022

Please consider at least making a free software (as in freedom) version possible for GNU/Linux distributions and Android. Making it possible for users to keep their freedoms in the ever more important digital world is the main reason the GNU project was started and the goal of the GNU GPL (GNU General Public Licence). Wikipedia as well is an adoption of these ideas and used the GNU FDL (GNU Free Documentation Licence) until 2008.

@mytja
Copy link
Member

mytja commented Apr 29, 2022

I know, I know, and I'm sorry. Android version is currently the most libre version. But the problem is harmonoid_visual_assets (which contains artworks and can simply be removed), but more importantly ytm_client.dart, which takes care of YouTube Music. Playback is fully libre, as we are using assets_audio_player. You can modify Harmonoid's source code to not contain these propriatery libs, but you are going to have to replace these libs, which can be a pain & you cannot distribute this modified version due to EULA. You can find details about that in README. I sadly cannot do anything more than tell you this.

@EmanuelLoos
Copy link
Author

you cannot distribute this modified version due to EULA

If it is not permitted to distribute modified versions of a software that software is non-free as per the Free Software Definition and not even an open source project as per the Open Source Definition. With this EULA not only some libs but the whole project (except for free libs) is non-free and not open source.

@mytja
Copy link
Member

mytja commented May 8, 2022

So, what do you want? Binaries are fully free to download. Where is the issue? Is it too hard to go and download binaries from GitHub? If it is, I suggest you to look at a different music player.

@mytja mytja closed this as completed May 8, 2022
@EmanuelLoos
Copy link
Author

Furthermore switching from the GPL to that EULA is only legal if 100% of the former GPL source code comes from people who agreed to this change. All contributors would have needed to agree, otherwise it was illegal.

@EmanuelLoos
Copy link
Author

So, what do you want? Binaries are fully free to download. Where is the issue? Is it this hard to go and download binaries from GitHub? If it is, I suggest you to look at a different music player.

If you would like to understand why this is important I would suggest reading the Free Software Definition. It is about freedom, not price.

@harmonoid harmonoid locked and limited conversation to collaborators May 8, 2022
@harmonoid harmonoid unlocked this conversation May 8, 2022
@alexmercerind
Copy link
Member

alexmercerind commented May 8, 2022

If it is not permitted to distribute modified versions of a software that software is non-free as per the Free Software Definition and not even an open source project as per the Open Source Definition. With this EULA not only some libs but the whole project (except for free libs) is non-free and not open source.

I have openly mentioned the licensing change from GPL to EULA everywhere in source code headers, changelog of v0.2.0 & the EULA file itself.

I wish to keep the project-specific packages private since I have spent a lot of time on those. I have written everything myself to pull this project off (see image below) & it hurts me a little when others just use my work (which I made specifically for this) without a second thought about the time I spent. After a long run of maintaining open-source packages at my GitHub profile, things haven't been very rewarding to say the least. Simply, I no longer want to set my code free in this project. I don't want people to redistribute project either since it takes away the "guarantee of it working properly", few (5-6) months back we had a FlatHub release (which I didn't work on) & it turns out it didn't work as intended/had-bugs which got project false reviews. I had to take it down. On the other hand, the enforcement of open-source licenses is REALLY hard & I can't bear my work getting stolen. There's no other reason to change the licensing. Eventually, if the sub-projects (see below) are made public, the licensing can be reverted to some FOSS license.

I'm actively working on newer features & improvements to make things better. Still, you may compare UI consistency, animations or fluid-ness, YT playback speeds or performances. Sorry I'm not making internal packages' source code public for now.

All contributors would have needed to agree, otherwise it was illegal.

I've written majority (like majority, majority) of the source code since v0.1.9 (complete rewrite, no longer same business logic, no longer same internal libraries, no longer same UI) or before that. I have 80%+ of the total commits and I have majorly made commits to actual source code files (no translation updates or fixing README typos) (to let alone this project), forgetting the internal actual native packages I made. Still, I hold the project license since it was started, it's my source code (no AUTHORS.txt) & I have the rights to change licensing. Now though, we have few files with copyrights from other people under this EULA. Recently, mpv, vlc relicensed some of their parts to LGPL from GPL & it's not realistically possible to convince everyone.

This is the list of projects I work on for Harmonoid, (I have random licenses in most of them in-case I ever decide to make them publicly available):
If you want to read every line of code in these sub-projects or wanna use them in your projects, you can just sponsor at Patreon or somewhere else. I will add you to our GitHub org & you'll be able to visit, see or comment on changes. But Linux or FOSS community doesn't believe in paying anything on the internet, so there's that. But sorry, I'm tired of open-source for now.

Screenshot_2022-04-27_230009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants