-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated de_DE.json #41
Conversation
I think that this duplicate is the reason the check failed. |
Yeah, it's duplicate. One has a period in it & another one doesn't. According to Material Design specification, full stops should be omitted when sentence exists alone (mobile) & should be preserved when in combination with other sentences i.e. a paragraph. Let's have both since few languages have different punctuation & symbols etc. Thanks for the translation updates! I'm about to release v0.3.5 with few important things in a while.
|
I have few other requests too. |
I can probably look at that tomorrow. |
removed full stops on lonley sentences shortend a few sentences according to Material Design
Fullfiled the requests you made, shoud be fine to merge. One question though, in german there is a formal and non-formal way of adressing someone, currently I used the formal way because its mostly the way software adresses the user, but now I sometime think it sounds a bit wierd. It also would be shorter to use the non-formal way in most cases. |
Sounds good to me! Thanks for the translations, feel free to edit them out as you like. |
Updated the German translation and corrected some grammar and spelling mistakes.
Also I noticed that
translations/translations/en_US.json
Line 72 in d3660a2
translations/translations/en_US.json
Line 73 in d3660a2