Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated de_DE.json #41

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Updated de_DE.json #41

merged 3 commits into from
Jan 5, 2023

Conversation

ken-der-guru
Copy link
Collaborator

Updated the German translation and corrected some grammar and spelling mistakes.

Also I noticed that

"EDIT_ALBUM_PARAMETERS_SUBTITLE": "Edit parameters used to uniquely identify an album",
and
"EDIT_ALBUM_PARAMETERS_SUBTITLE_": "Edit parameters used to uniquely identify an album.",
are the same, therefore I think one of them should get removed to avoid confusion.

@ken-der-guru
Copy link
Collaborator Author

I think that this duplicate is the reason the check failed.

@alexmercerind
Copy link
Member

alexmercerind commented Jan 4, 2023

Yeah, it's duplicate. One has a period in it & another one doesn't.

According to Material Design specification, full stops should be omitted when sentence exists alone (mobile) & should be preserved when in combination with other sentences i.e. a paragraph. Let's have both since few languages have different punctuation & symbols etc.


Thanks for the translation updates! I'm about to release v0.3.5 with few important things in a while.

Some necessary fixes important for project to receive quickly. Most importantly:

  • NAS / Samba file-system support for Windows has been fixed.
  • Thumbnail toolbar is no longer missing on Windows.
  • Some specific ROMs/devices will no longer face playback issues on Android.
  • Issue that caused opening music from File Explorer to make Harmonoid window restored on Windows has been fixed.
  • Harmonoid window no longer freezes when quitting on Windows 7 (backward-compatibility).

Highlights

  • Fixed NAS / SMB support on Windows.
  • Fixed issue that caused opening file from File Explorer to make Harmonoid window restored (if already maximized) on Windows.
  • Added ability to disable all audio filters on Android (disabled by default). Some ROMs & devices are having trouble.
  • Disabled GTK header-bar on GNOME desktop environment.
  • Fixed unresponsive process when closing window on Windows 7 only.
  • Updated new page animation when clicking on hyperlinks.
  • Added support for installing for current users only on Windows (#372).
  • Fixed next/previous buttons not greyed out in ModernNowPlayingScreen (#369).
  • Made fallback album arts configurable (#379).
  • Fixed missing thumbnail toolbar buttons on Windows.
  • Fixed "CANCEL" button on minimum file size dialog popping Navigator on the wrong BuildContext.
  • Migrated project to API changes in package:media_kit.
  • Safer hyperlinks. Added null-check after lookup for album/artist in package:media_library HashSet(s) (#366).
  • Added multiple genre support (not exposed yet).
  • Added Play all button next to Shuffle on Albums & Artists screens to play them orderly.
  • Now background visuals are stored as animated WebP.
    This has significantly reduced bundle size & also improved Linux's performance with ModernNowPlayingScreen (?).

@alexmercerind
Copy link
Member

alexmercerind commented Jan 4, 2023

I have few other requests too.
Can we shorten few labels, maybe change grammar slightly or whatever while still conveying message?

@ken-der-guru
Copy link
Collaborator Author

I can probably look at that tomorrow.

removed full stops on lonley sentences
shortend a few sentences according to  Material Design
@ken-der-guru
Copy link
Collaborator Author

Fullfiled the requests you made, shoud be fine to merge.

One question though, in german there is a formal and non-formal way of adressing someone, currently I used the formal way because its mostly the way software adresses the user, but now I sometime think it sounds a bit wierd. It also would be shorter to use the non-formal way in most cases.
Let me hear your thoughts on that

@alexmercerind
Copy link
Member

Sounds good to me! Thanks for the translations, feel free to edit them out as you like.

@alexmercerind alexmercerind merged commit 4da36b7 into harmonoid:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants