Merge pull request #463 from harmony-ek/fix_stream_leak

Fix stream leak
harmony-one · Feb 16, 2019 · 844bb37 · 844bb37
2 parents b875062 + f96ad97
commit 844bb37
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/p2p/host/hostv2/hostv2.go b/p2p/host/hostv2/hostv2.go
@@ -222,6 +222,11 @@ func (host *HostV2) SendMessage(p p2p.Peer, message []byte) error {
 			"protocolID", ProtocolID, "error", err)
 		return p2p.ErrNewStream
 	}
+	defer func() {
+		if err := s.Close(); err != nil {
+			logger.Warn("cannot close stream", "error", err)
+		}
+	}()
 	if nw, err := s.Write(message); err != nil {
 		logger.Error("Write() failed", "peerID", p.PeerID,
 			"protocolID", ProtocolID, "error", err)