Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert bad blocks #1295

Merged
merged 3 commits into from Aug 7, 2019
Merged

Revert bad blocks #1295

merged 3 commits into from Aug 7, 2019

Conversation

rlan35
Copy link
Contributor

@rlan35 rlan35 commented Aug 7, 2019

No description provided.

@rlan35 rlan35 requested a review from harmony-ek August 7, 2019 01:44
Copy link
Contributor

@harmony-ek harmony-ek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a warning log inside the if block to display the range being reverted, and g2g.

@rlan35 rlan35 changed the base branch from master to r3 August 7, 2019 01:51
chain := currentNode.Blockchain()
curNum := chain.CurrentBlock().NumberU64()
if curNum < uint64(*doRevertBefore) && curNum >= uint64(*revertTo) {
utils.GetLogInstance().Warn("[WARNING] Reverting blocks",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be fixed using zerolog.

@harmony-ek harmony-ek merged commit a7ec3b2 into harmony-one:r3 Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants