-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging for NthNextHmy
panic
#4341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxMustermann2
commented
Jan 17, 2023
ONECasey
approved these changes
Jan 17, 2023
5931336
to
b434fd3
Compare
This reverts commit b434fd3. We have fixed the cause of the issue, which was time drift on a new cloud provider's nodes. See `systemd-timesyncd.service` Even if this fix had been merged, it would likely not have solved the problem given those nodes with the correct time would pick a different leader from those with time drift. Or, in other words, the view change would not have gone through.
f9c2cef
to
dd62a54
Compare
Seems to be failing one of the CI tests. |
GheisMohammadi
approved these changes
Jan 19, 2023
sophoah
approved these changes
Jan 20, 2023
The test was logging too much. Logging was piped to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps confirm that #4340 is caused by time drift.
(gap in view ids + current leader index) % number of internal keys
. The gap acts as an offset parameter, and can be negative.a % b
is negative ifa
is negative..See private Discord thread here for logs.
Solution
On all nodes which could potentially have this issue, install and enable the
systemd
service to synchronize time with NTP servers.