-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Candidate 2023.2.3 #4458
Conversation
With #4427, the protofiles are generated using a Docker image and thus `protoc` related binaries are not required. However, `mockgen` and `golangci-lint` are still being used by our Travis build. This change restores the file that installs them, and removes `protoc` related files from the list of installations.
Waiting for hard fork PR from @MaxMustermann2 |
/*) progdir="/";; | ||
*/*) progdir="${0%/*}";; | ||
*) progdir="."; | ||
esac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the current directory path follows the pattern /*
then progdir
will be /
which gives the wrong path in line 12, because line 12 assumes the /
won't be there and it hard-coded the slash.
from line 5 to line 10 could be replaced with this simple command:
progdir="$(dirname "${0}")"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I just restored the file that was deleted. Feel free to make edits in a separate PR. Now that the build is working it'll be pretty easy to test. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
#4457