Merge pull request #524 from harness/CCM-12214

Bug: [CCM-12214]: Setting the attributes only if the billing feature is enabled
harness · Apr 28, 2023 · 4d4994d · 4d4994d
2 parents f289e83 + 524467c
commit 4d4994d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 5 deletions.
diff --git a/.changelog/524.txt b/.changelog/524.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/harness_platform_connector_awscc: Fix bug in aws cloud cost connector resource
+```
diff --git a/internal/service/platform/connector/aws_cc.go b/internal/service/platform/connector/aws_cc.go
@@ -162,8 +162,10 @@ func buildConnectorAwsCC(d *schema.ResourceData) *nextgen.ConnectorInfo {
 
 func readConnectorAwsCC(d *schema.ResourceData, connector *nextgen.ConnectorInfo) error {
 	d.Set("account_id", connector.AwsCC.AwsAccountId)
-	d.Set("report_name", connector.AwsCC.CurAttributes.ReportName)
-	d.Set("s3_bucket", connector.AwsCC.CurAttributes.S3BucketName)
+	if isFeatureEnabled("BILLING", connector.AwsCC.FeaturesEnabled) {
+		d.Set("report_name", connector.AwsCC.CurAttributes.ReportName)
+		d.Set("s3_bucket", connector.AwsCC.CurAttributes.S3BucketName)
+	}
 	// d.Set("s3_prefix", connector.AwsCC.CurAttributes.S3Prefix)
 	// d.Set("region", connector.AwsCC.CurAttributes.Region)
 	d.Set("features_enabled", connector.AwsCC.FeaturesEnabled)
@@ -176,3 +178,12 @@ func readConnectorAwsCC(d *schema.ResourceData, connector *nextgen.ConnectorInfo
 
 	return nil
 }
+
+func isFeatureEnabled(value string, list []string) bool {
+	for _, v := range list {
+		if strings.EqualFold(value, v) {
+			return true
+		}
+	}
+	return false
+}
diff --git a/internal/service/platform/connector/aws_cc_test.go b/internal/service/platform/connector/aws_cc_test.go
@@ -10,7 +10,7 @@ import (
 )
 
 func TestAccResourceConnectorAwsCC(t *testing.T) {
-	t.Skip("Skipping until account id issue is fixed https://harness.atlassian.net/browse/PL-20793")
+	//t.Skip("Skipping until account id issue is fixed https://harness.atlassian.net/browse/PL-20793")
 
 	id := fmt.Sprintf("%s_%s", t.Name(), utils.RandStringBytes(5))
 	name := id
@@ -64,13 +64,13 @@ func testAccResourceConnectorAwsCC(id string, name string) string {
 			description = "test"
 			tags = ["foo:bar"]
 
-			account_id = "000000000001"
+			account_id = "123456789012"
 			report_name = "test_report"
 			s3_bucket = "s3bucket"
 			features_enabled = [
 				"OPTIMIZATION",
 				"VISIBILITY",
-				"BILLING",
+				"BILLING"
 			]
 			cross_account_access {
 				role_arn = "arn:aws:iam::123456789012:role/S3Access"