fix: aws_cc make cur optional

[rssnyder]

Describe your changes

The AWS CC connector type has an optional field for the CUR. The current state of this resource makes this a required field.

https://apidocs.harness.io/tag/Connectors#operation/createConnector
https://harness.slack.com/archives/C02GHCDN2JV/p1689087248164719

Tested locally:

Terraform will perform the following actions:

  # harness_platform_connector_awscc.accounts will be created
  + resource "harness_platform_connector_awscc" "accounts" {
      + account_id       = "166719183214"
      + features_enabled = [
          + "GOVERNANCE",
          + "VISIBILITY",
        ]
      + id               = (known after apply)
      + identifier       = "aws166719183214"
      + name             = "lz-test-plat"

      + cross_account_access {
          + external_id = "harness:891928451355:pC_7h33wQTeZ_j-libvF4A"
          + role_arn    = "arn:aws:iam::166719183214:role/HarnessCERole"
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

harness_platform_connector_awscc.accounts: Creating...
harness_platform_connector_awscc.accounts: Creation complete after 0s [id=aws166719183214]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

tf import harness_platform_connector_awscc.accounts aws166719183214
harness_platform_connector_awscc.accounts: Importing from ID "aws166719183214"...
harness_platform_connector_awscc.accounts: Import prepared!
  Prepared harness_platform_connector_awscc for import
harness_platform_connector_awscc.accounts: Refreshing state... [id=aws166719183214]

Import successful!

The resources that were imported are shown above. These resources are now in
your Terraform state and will henceforth be managed by Terraform.

➜  test tf apply
╷
│ Warning: Provider development overrides are in effect
│ 
│ The following provider development overrides are set in the CLI configuration:
│  - harness/harness in /Users/rileysnyder/git/terraform-provider-harness
│ 
│ The behavior may therefore not match any released version of the provider and applying changes may cause the state to become incompatible with published releases.
╵
harness_platform_connector_awscc.accounts: Refreshing state... [id=aws166719183214]

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Comment Triggers

PR Check triggers

• Build: trigger build
• Sub Category Field Check: trigger subcategoryfieldcheck

[Rohit-Kaliki]

trigger build

[Rohit-Kaliki]

trigger subcategoryfieldcheck

[rathodmeetsatish]

@nikunj-badjatya @Rohit-Kaliki @RajBaviskar there is schema change so this will require doc update as well and dont we need any new tests to test these changes? and have we ran existing tests on one of the prod account? and please also add changelog file

[rssnyder]

@nikunj-badjatya @Rohit-Kaliki @RajBaviskar @rathodmeetsatish I made an attempt at adding tests and updating the docs to show the now optional fields. Can I get a review?

[rssnyder]

trigger build

[rssnyder]

trigger subcategoryfieldcheck

[rathodmeetsatish]

add changelog file

[rssnyder]

trigger build

[rssnyder]

trigger subcategoryfieldcheck

[rssnyder]

trigger build

[rssnyder]

trigger subcategoryfieldcheck

[rssnyder]

trigger build

[rssnyder]

trigger subcategoryfieldcheck

[rssnyder]

trigger build

[rssnyder]

trigger subcategoryfieldcheck

[rssnyder]

@rathodmeetsatish gitleaks is failing due to this PR being from a fork and not a branch on this repo. Can you force merge or what are my options here?