Fix types so that all types are exported #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping in a namespace causes that only the types for those functions are exported.
* Since `parseExpression` is just a wrapper for `CronExpression.parse`, just point to the type for `CronExpression.parse`. * Export more interfaces. * The return type for callbacks should be `void`, since the return value is ignored. * The type for errors is `any`.
* Add a generic to flag whether methods will return a `CronDate` or an `IteratorResult`. * Add the `nthDayOfWeek` property to the `ParserOptions` interface. * Expand the valid types for the `resetDate` parameter of the `reset` method. * Correct the `parse` method to be static.
* Add types for the constructor, since it's not marked as private. (Technically, `tz` can also be a Luxon `Zone`, but I didn't want to add a dependency on `@types/luzon`). * Add the `isLastDayOfMonth` method.
|
@BehindTheMath closing this favour of #214. Let me know there is something missing or can be improved further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping in a namespace causes that only the types for those functions are exported.