fix: env is not passed to worker threads (nightwatchjs#3691)

harshit-bs · Apr 20, 2023 · ac3c506 · ac3c506
1 parent 2bb54d3
commit ac3c506
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/runner/concurrency/worker-process.js b/lib/runner/concurrency/worker-process.js
@@ -30,6 +30,7 @@ class WorkerPool extends EventEmitter {
       maxThreads: maxWorkerCount,
       argv: args,
       env: {
+        ...process.env,
         __NIGHTWATCH_PARALLEL_MODE: '1'
       }
     });

diff --git a/test/src/runner/cli/testCliRunnerParallel.js b/test/src/runner/cli/testCliRunnerParallel.js
@@ -19,11 +19,11 @@ describe('Test CLI Runner in Parallel', function () {
     });
   }
 
-  before(function() {
+  beforeEach(function() {
     mockery.enable({useCleanCache: true, warnOnReplace: false, warnOnUnregistered: false});
   });
 
-  after(function() {
+  afterEach(function() {
     mockery.deregisterAll();
     mockery.resetCache();
     mockery.disable();
@@ -66,6 +66,7 @@ describe('Test CLI Runner in Parallel', function () {
   });
 
   it('test run geckodriver with concurrency - worker threads', function () {
+    process.env.TEST_ENV = 'TEST';
     class RunnerBaseMock extends RunnerBase {
       static readTestSource(settings, argv) {
         assert.strictEqual(settings.testWorkersEnabled, true);
@@ -80,6 +81,11 @@ describe('Test CLI Runner in Parallel', function () {
     class WorkerProcessMock extends WorkerProcess {
       addTask({colors}) {
         assert.strictEqual(colors.length, 4);
+        assert.strictEqual(this.piscina.options.env.TEST_ENV, 'TEST');
+        assert(Object.keys(this.piscina.options.env).length > 1, 'process.env should have more than one key');
+
+        // cleaning the env
+        process.env.TEST_ENV = undefined;
 
         return Promise.resolve(0);
       }