New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: env is not passed to worker threads #3691
fix: env is not passed to worker threads #3691
Conversation
@vaibhavsingh97 can we have a test for windows to catch something like this in the future? A test to check if chromedriver/geckodriver gets started properly. |
Looks good. Should we add a test reflecting envs variables are passed onto worker threads? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will not be running e2e tests against public websites as part of the main build, for a number of reasons:
- the build will become too slow and difficult to manage
- since we don't control those websites, we shouldn't rely on their availability
In addition, these tests are not suitable for v3, since they are written using the v2 apis and so they should be part of a separate example repository.
9adfeee
to
97d5783
Compare
Fixes: #3686
Fixes: #3687
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
features/my-new-feature
orissue/123-my-bugfix
);