Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: env is not passed to worker threads #3691

Merged
merged 7 commits into from Apr 20, 2023

Conversation

vaibhavsingh97
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 commented Apr 12, 2023

Fixes: #3686
Fixes: #3687
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@swrdfish
Copy link
Member

@vaibhavsingh97 can we have a test for windows to catch something like this in the future? A test to check if chromedriver/geckodriver gets started properly.

@gravityvi
Copy link
Member

Looks good. Should we add a test reflecting envs variables are passed onto worker threads?

Copy link
Member

@gravityvi gravityvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some tests

Copy link
Member

@beatfactor beatfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will not be running e2e tests against public websites as part of the main build, for a number of reasons:

  1. the build will become too slow and difficult to manage
  2. since we don't control those websites, we shouldn't rely on their availability

In addition, these tests are not suitable for v3, since they are written using the v2 apis and so they should be part of a separate example repository.

@beatfactor beatfactor merged commit ac3c506 into nightwatchjs:main Apr 20, 2023
7 checks passed
@vaibhavsingh97 vaibhavsingh97 deleted the bugfix/window-env branch April 20, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants