Makefile: do not run depmod manually #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel build infrastructure already runs depmod properly in its modules_install target, doing so in a cross-compilation friendly way. Running it with no arguments is useless and also harmful since it breaks cross-compilation contexts by scanning dependencies on the modules installed on the host instead of those being built for the target. Signed-off-by: Andrea Galbusera <gizero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel build infrastructure already runs depmod properly in its
modules_install target, doing so in a cross-compilation friendly way. Running it
with no arguments is useless and also harmful since it breaks cross-compilation
contexts by scanning dependencies on the modules installed on the host instead
of those being built for the target.
Patches with similar motivation where accepted by other projects providing external kernel modules and widely used in cross-compilation environments. See i.e. lttng-modules or v4l2loopback as a reference.