Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Tag, Filter and Drop interfaces? #107

Closed
scottge opened this issue Feb 25, 2019 · 2 comments
Closed

Export Tag, Filter and Drop interfaces? #107

scottge opened this issue Feb 25, 2019 · 2 comments
Milestone

Comments

@scottge
Copy link

scottge commented Feb 25, 2019

Hi

In earlier version of liquidjs, Tag and Filter are exported, and I can define my custom tag or filter by implementing those interfaces.

In 7.*, these interfaces are not exported. Would you consider exporting your Tag, Filter and Drop interfaces?

@harttle
Copy link
Owner

harttle commented Feb 26, 2019

To register a tag or filter, just use .registerTag(), .registerFilter() interface, and the type definitions are already exported for TypeScript clients.

As for the Drop, that's not fully implemented. Although you can pass in any object as context with a liquid_method_missing method and that method will be respected, I'm not encouraging you to do so because Drops are not fully functional for now and that method will be renamed soon #109.

I plan to make Drops ready to use in the next major version. I appreciate it very much that you keep trying those new features and helps a lot to enhance them.

@harttle harttle added this to the 8.0.0 milestone Feb 26, 2019
harttle added a commit that referenced this issue Feb 27, 2019
Deprecate snake_cased options and APIs, sed #109
harttle pushed a commit that referenced this issue Feb 28, 2019
# [7.4.0](v7.3.1...v7.4.0) (2019-02-28)

### Bug Fixes

* math filters now return number, resolves [#110](#110) ([b4acdb4](b4acdb4))

### Features

* exported Drop interface for [#107](#107) ([7bee9fc](7bee9fc)), closes [#109](#109)
@harttle
Copy link
Owner

harttle commented Mar 1, 2019

Now Drop is exported via Liquid.Types.Drop, please refer to the e2e case. And you can find more cases in the unit test. If you got any problems, or if I made any mistakes, or it cannot be used the same way as the shopify/liquid, report it here please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants