Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with minus help and for-in #110

Closed
jviney opened this issue Feb 27, 2019 · 0 comments · May be fixed by maze-consulting/liquidjs#1
Closed

Problem with minus help and for-in #110

jviney opened this issue Feb 27, 2019 · 0 comments · May be fixed by maze-consulting/liquidjs#1
Labels

Comments

@jviney
Copy link

jviney commented Feb 27, 2019

This used to work on 7.2.0, and broke in 7.2.1.

  it('should support for-in with variable', async function () {
    const src = '{% assign total = 3 | minus: 1 %}' +
      '{% for i in (1..total) %}{{ i }}{% endfor %}'
    const html = await liquid.parseAndRender(src, {})
    return expect(html).to.equal('12')
  })

Instead of looping up to 2, it now loops up to 20. Seems to be multiplying by 10 for some reason.

@harttle harttle added the bug label Feb 28, 2019
harttle pushed a commit that referenced this issue Feb 28, 2019
# [7.4.0](v7.3.1...v7.4.0) (2019-02-28)

### Bug Fixes

* math filters now return number, resolves [#110](#110) ([b4acdb4](b4acdb4))

### Features

* exported Drop interface for [#107](#107) ([7bee9fc](7bee9fc)), closes [#109](#109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants