feature: pass query as env variables

fixtures/echo-word.sh

@@ -0,0 +1 @@
+echo before ${word} after

fixtures/shellhubrc.json

@@ -7,6 +7,10 @@
             "cwd": "./",
             "cmd": "bash hello-world.sh"
         },
+        "/echo/word": {
+            "cwd": "./",
+            "cmd": "bash echo-word.sh"
+        },
         "/with/error": {
             "cwd": "./",
             "cmd": "echo first line >&2 && echo second line && echo third line >&2"

src/server.js

@@ -9,12 +9,12 @@ var config;
 
 function controller(req, res) {
     config.reload();
-    var pathname = url.parse(req.url).pathname;
-    var entry = config.scripts[pathname];
+    var urlObj = url.parse(req.url, true)
+    var entry = config.scripts[urlObj.pathname];
 
     res.setHeader('content-type', 'text/plain')
     if (!entry) {
-        var msg = 'path ' + pathname + ' not registered';
+        var msg = 'path ' + urlObj.pathname + ' not registered';
         log(msg);
         res.statusCode = 404;
         res.end(msg);
@@ -27,14 +27,31 @@ function controller(req, res) {
     log(msg);
     res.write(msg);
 
-    var proc = spawn('bash', ['-c', '( ' + entry.cmd + ' ) 2>&1'], {
+    var loader = exports.loader(entry.cmd, urlObj.query)
+    var proc = spawn('bash', ['-c', loader], {
         cwd: entry.cwd
     });
 
     proc.stdout.pipe(res);
     proc.stdout.pipe(process.stdout);
 }
 
+exports.loader = function(cmd, query){
+    var r = /^\w+$/
+    var vars = Object
+        .keys(query)
+        .map(function(key){
+            var val = query[key];
+            if (r.test(key) && r.test(val)) {
+                return 'export ' + key + '=' + val + ';'
+            } else {
+                return ''
+            }
+        })
+        .join('')
+    return vars + '( ' + cmd + ' ) 2>&1'
+}
+
 exports.mkServer = function(cfg) {
     config = cfg;
     return http.createServer(controller);

test/server.js

@@ -1,5 +1,7 @@
 const request = require('supertest');
 const server = require('../src/server.js');
+const chai = require('chai')
+const expect = chai.expect
 const Config = require('../src/config.js');
 const fs = require('fs');
 const path = require('path');
@@ -34,6 +36,28 @@ describe('server', function() {
             .expect(/first line\nsecond line\nthird line/);
     });
 
+    it('should pass query as variables into bash', function() {
+        return request(app)
+            .get('/echo/word?word=WORD')
+            .expect(200)
+            .expect(/before WORD after/);
+    });
+
+    it('should generate loader', function() {
+        var ret = server.loader('echo', {})
+        expect(ret).to.equal('( echo ) 2>&1')
+    });
+
+    it('should generate loader according to query', function() {
+        var ret = server.loader('echo', {foo: 'bar'})
+        expect(ret).to.equal('export foo=bar;( echo ) 2>&1')
+    });
+
+    it('should skip non work characters in query', function() {
+        var ret = server.loader('echo', {foo: '-bar', bar: 'baz'})
+        expect(ret).to.equal('export bar=baz;( echo ) 2>&1')
+    });
+
     it('should capture child outputs', function() {
         return request(app)
             .get('/spawn')