use valid value for X-Frame-Options #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
requested changes
May 21, 2020
There was a problem hiding this comment.
Okay… I forgot where I read to use SAMESITE or if I just didn't pay close enough attention to the exact value. Interestingly, SAMESITE made the iframe work for both my Chromium and my Firefox. Is that expected?
The CI fails because I added a test case that needs adjustment to the new header value now. Could you get the test back in sync?
|
I guess it "worked" because an invalid value is the same as not setting the header at all. |
hartwork
approved these changes
May 21, 2020
|
PS: Fix deployed to https://jawanndenn.de/ by now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAMESITE is not a valid value for the X-Frame-Options header.
This is also causing an error in the Firefox developer console:
The intention was probably to set it to sameorigin, see:
https://developer.mozilla.org/de/docs/Web/HTTP/Headers/X-Frame-Options