Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use valid value for X-Frame-Options #46

Merged
merged 2 commits into from May 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion jawanndenn/tests/test_views.py
Expand Up @@ -175,7 +175,7 @@ class ServeUsingFindersTest(TestCase):

# Our app, asset used in <iframe>
('jawanndenn', '3rdparty/github-buttons-4.0.1/docs/github-btn.html',
'SAMESITE'),
'sameorigin'),

# Arbitrary asset of arbitary other app
('django.contrib.admin', 'admin/css/responsive.css', 'DENY'),
Expand Down
2 changes: 1 addition & 1 deletion jawanndenn/urls.py
Expand Up @@ -31,7 +31,7 @@ def _serve_with_headers_fixed(request, path, insecure=False, **kwargs):
# Allow loading of github-btn.html in an <iframe>
if (path.startswith('3rdparty/github-buttons-')
and path.endswith('/docs/github-btn.html')):
response['X-Frame-Options'] = 'SAMESITE'
response['X-Frame-Options'] = 'sameorigin'

return response

Expand Down