Css padding fixes #935
Merged
Css padding fixes #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get margins looking right on the /terms page, and adjust the margins between sections on all the other pages.
Terms:
Other pages using h2.subtitle for section headers:
Gallery:
Specific changes in the PR:
Refactor some scss files to avoid redundant imports. Mostly that was by moving a mixin for the colored-footer files from base.scss to variables.scss. One exception, index.scss has to import base.scss, so I tweaked main_base.html and index.html to make sure that base.scss itself wasn't also included on the homepage.
Remove the
<div class="page-section">element (almost all the changes here are just removing that element and reindenting).Move the margin-top and margin-bottom that were on .page-section to be on .main-content and h2.subtitle instead.
Custom padding in gallery.scss since it wasn't using h2.subtitle for spacing between projects