New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt 2 to fix https://github.com/harvard-lil/perma/issues/2416 #2420

Merged

bensteinberg merged 1 commit into harvard-lil:develop from rebeccacremona:unicode-attrs2

Jul 17, 2018

Contributor

rebeccacremona commented Jul 16, 2018

If pywb is expecting latin-1, give it latin-1.

This seems to allow correct playback of the three urls....

....all at the same time.

This makes a bit more sense than the last attempt. But, I still want to confer w/ the WR team about how pywb handles encoding.


          Attempt 2.

c9c25b5

coveralls commented Jul 16, 2018

Coverage increased (+0.02%) to 82.977% when pulling c9c25b5 on rebeccacremona:unicode-attrs2 into b1cdb65 on harvard-lil:develop.

bensteinberg merged commit 1721538 into harvard-lil:develop

rebeccacremona deleted the unicode-attrs2 branch

July 17, 2018 13:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet