fix for file utility html detection bug #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proposed fix for bug harvard-lts#95 Up until now if mime type starts with 'text/' the format gets hardcoded to 'Plain text'. But according to fileutility_to_fits.xslt the format has to be 'HTML document text', otherwise the format will be empty. fix: 1.) don't hardcode everything that starts with 'text/' (if necessary, only for 'text/plain') 2.) write regex inside fileutility_to_fits.xslt for text/html, because different file utility versions might output different output strings
|
Thanks for your contribution. This will be a part of the upcoming FITS release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed fix for bug #95
Up until now if mime type starts with 'text/' the format gets hardcoded to 'Plain text'.
But according to fileutility_to_fits.xslt the format has to be 'HTML document text',
otherwise the format will be empty.
fix:
1.) don't hardcode everything that starts with 'text/' (if necessary, only for 'text/plain')
2.) write regex inside fileutility_to_fits.xslt for text/html, because different
file utility versions might output different output strings