Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tlm support #8

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix tlm support #8

merged 2 commits into from
Mar 5, 2024

Conversation

jcupitt
Copy link
Collaborator

@jcupitt jcupitt commented Mar 5, 2024

tlm needs target rewrite

see #5

tlm needs target rewrite

see #5
@jcupitt
Copy link
Collaborator Author

jcupitt commented Mar 5, 2024

Test with eg.:

$ vips kakadusave k2.jpg x.jp2 --options "Qfactor=90 Cmodes=HT ORGgen_plt=yes Creversible=no Cblk={64,64} ORGtparts=R ORGgen_tlm=9"

** (vips:38242): WARNING **: 17:23:15.321: Kakadu Core Warning:
The `Qweights' parameter values supplied are not a close match to the
square-root of the synthesis energy gains of the prevailing multi-component
transform, if any, in tile 0.  Use the following parameters: 1.732051,
1.805108, 1.573402.

There's a test in the test suite too.

@scossu
Copy link
Collaborator

scossu commented Mar 5, 2024

This seems to work now—at least it creates a JP2 with no warning. Do you know how I can inspect the image for the TLM marker?

@jcupitt
Copy link
Collaborator Author

jcupitt commented Mar 5, 2024

Sorry, I'm not sure. You can see that the bytes in the file change with this option, maybe that's enough?

@scossu
Copy link
Collaborator

scossu commented Mar 5, 2024

I guess we'll merge this in for now, maybe I can ask the Kakadu devs if there are specific metadata flags to detect these features.

@scossu scossu merged commit 1a73412 into main Mar 5, 2024
@scossu scossu deleted the fix-tlm branch March 5, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants